Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect exit status if deploy fails #95

Merged
merged 1 commit into from
May 14, 2014

Conversation

borovsky
Copy link
Contributor

  1. If exit status is greater than 255, it returned as 0 (success)
  2. Process::Status.to_i returns status shifted left by 8 (Documentation)

As result if deployment script fails, mina returns success status (and build not fails)

It's fix for this problem.

@rstacruz
Copy link
Member

That's a very interesting find!

On Wednesday, February 13, 2013, Alexander Borovsky wrote:

  1. If exit status is greater than 255, it returned as 0 (success)
  2. Process::Status.to_i returns status shifted left by 8 (Documentationhttp://rubydoc.info/stdlib/core/Process/Status
    )

As result if deployment script fails, mina returns success status (and
build not fails)

It's fix for this problem.

You can merge this Pull Request by running

git pull https://github.com/borovsky/mina fix-exit-status

Or view, comment on, or merge it at:

#95
Commit Summary

  • Fixed exit status returning

File Changes

Patch Links:

@ghost ghost assigned mikong Jul 14, 2013
gabskoro added a commit that referenced this pull request May 14, 2014
@gabskoro gabskoro merged commit c563ea6 into mina-deploy:master May 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants