Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New function to use completing-read as the UI for completion-at-point #31

Merged
merged 8 commits into from
Dec 6, 2020
Merged

New function to use completing-read as the UI for completion-at-point #31

merged 8 commits into from
Dec 6, 2020

Commits on Dec 4, 2020

  1. New function to use completing-read as the UI for completion-at-point

    @oantolin
    oantolin committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    db4654e View commit details
    Browse the repository at this point in the history

  2. Stop handling the minibuffer case specially

    @oantolin
    oantolin committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    9bbf831 View commit details
    Browse the repository at this point in the history

  3. Handle the :exit-function property

    @oantolin
    oantolin committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    eebb2f3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into completion-in-region

    @oantolin
    oantolin committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    ed26e16 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2020

  1. Merge branch 'master' into completion-in-region

    @oantolin
    oantolin committed Dec 5, 2020
    Configuration menu
    Copy the full SHA
    e1ea314 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2020

  1. Merge branch 'master' into completion-in-region

    @oantolin
    oantolin committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    ec38cfa View commit details
    Browse the repository at this point in the history

  2. Use read-file-name for file completion instead of completing-read 

    This is nice in case the user has a special value of
read-file-name-function or special key bindings
in minibuffer-local-filename-completion-map.
    @oantolin
    oantolin committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    e5fb13a View commit details
    Browse the repository at this point in the history

  3. Only call exit function if there was a completion 

    Also, correctly set the exit status to sole for the case of a unique
completion.
    @oantolin
    oantolin committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    18cf843 View commit details
    Browse the repository at this point in the history