Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trusty rule and profile with new fields #116

Merged
merged 3 commits into from
May 27, 2024

Conversation

puerco
Copy link
Contributor

@puerco puerco commented May 23, 2024

This PR updates the trusty ruletype and the dependencies profile to use the new configurationfields exposed by recent enhancements to the trusty evaluator.

Note that the profile configures the rule to review PRs by default (as opposed to just adding a comment).

Signed-off-by: Adolfo García Veytia (puerco) <puerco@stacklok.com>
This commit adds an allow_malicious flag to the PR

Signed-off-by: Adolfo García Veytia (puerco) <puerco@stacklok.com>
This commit updates the trusty config in the deps profile to
use the new configuration fields exposed by the trusty evaluator.

Signed-off-by: Adolfo García Veytia (puerco) <puerco@stacklok.com>
@puerco
Copy link
Contributor Author

puerco commented May 23, 2024

Damn, I forgot about forks again. Sorry :/

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puerco I'm sorry I didn't review this PR for so long. Feel free to send a slack or discord reminder next time! Feel free to push just please note that the smoke tests might need adjusting (we'll see them failing)

@JAORMX JAORMX merged commit b070900 into mindersec:main May 27, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants