Skip to content

Commit

Permalink
Backfill latest_evaluation_statuses with profile_id
Browse files Browse the repository at this point in the history
Backfill this column and make it non nullable. Note that due to the
sequencing of production deploys, there should not be any
`latest_evaluaion_statuses` rows in production which do not have a
`profile_id` - this migration is only relevant for staging and local
dev environments.
  • Loading branch information
dmjb committed Jul 29, 2024
1 parent eec1a30 commit 25587db
Show file tree
Hide file tree
Showing 5 changed files with 50 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
-- Copyright 2024 Stacklok, Inc
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.

ALTER TABLE latest_evaluation_statuses ALTER COLUMN profile_id DROP NOT NULL;
28 changes: 28 additions & 0 deletions database/migrations/000082_backfill_latest_eval_profile_id.up.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
-- Copyright 2024 Stacklok, Inc
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.

BEGIN;

-- backfill rows which don't have a profile ID
UPDATE latest_evaluation_statuses
SET profile_id = ri.profile_id
FROM rule_instances AS ri
JOIN evaluation_rule_entities AS ere ON ere.rule_id = ri.id
JOIN latest_evaluation_statuses AS les ON les.rule_entity_id = ere.id
WHERE les.profile_id IS NULL;

-- make field mandatory
ALTER TABLE latest_evaluation_statuses ALTER COLUMN profile_id SET NOT NULL;

COMMIT;
6 changes: 3 additions & 3 deletions internal/db/eval_history.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions internal/db/models.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions internal/history/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,7 @@ func (_ *evaluationHistoryService) createNewStatus(
db.UpsertLatestEvaluationStatusParams{
RuleEntityID: ruleEntityID,
EvaluationHistoryID: newEvaluationID,
ProfileID: uuid.NullUUID{
UUID: profileID,
Valid: true,
},
ProfileID: profileID,
},
)
if err != nil {
Expand Down

0 comments on commit 25587db

Please sign in to comment.