Align sort inversion with pagination direction.

Fixes #3966
mindersec · Jul 23, 2024 · 467530f · 467530f
1 parent 2b5bb5d
commit 467530f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/internal/history/service.go b/internal/history/service.go
@@ -204,7 +204,7 @@ func (_ *evaluationHistoryService) ListEvaluationHistory(
 		return nil, errors.New("internal error")
 	}
 
-	if cursor != nil && cursor.Direction == Next {
+	if cursor != nil && cursor.Direction == Prev {
 		slices.Reverse(rows)
 	}
 

diff --git a/internal/history/service_test.go b/internal/history/service_test.go
@@ -210,7 +210,7 @@ func TestListEvaluationHistory(t *testing.T) {
 
 		// cursor flips on direction
 		{
-			name: "prev does not flip",
+			name: "next does not flip",
 			dbSetup: dbf.NewDBMock(
 				withListEvaluationHistory(nil, nil,
 					makeHistoryRow(
@@ -230,7 +230,7 @@ func TestListEvaluationHistory(t *testing.T) {
 				),
 			),
 			cursor: &ListEvaluationCursor{
-				Direction: Prev,
+				Direction: Next,
 			},
 			checkf: func(t *testing.T, rows *ListEvaluationHistoryResult) {
 				t.Helper()
@@ -251,7 +251,7 @@ func TestListEvaluationHistory(t *testing.T) {
 			},
 		},
 		{
-			name: "next does flip",
+			name: "prev does flip",
 			dbSetup: dbf.NewDBMock(
 				withListEvaluationHistory(nil, nil,
 					makeHistoryRow(
@@ -271,7 +271,7 @@ func TestListEvaluationHistory(t *testing.T) {
 				),
 			),
 			cursor: &ListEvaluationCursor{
-				Direction: Next,
+				Direction: Prev,
 			},
 			checkf: func(t *testing.T, rows *ListEvaluationHistoryResult) {
 				t.Helper()