Update AssignRole, RemoveRole and add new UpdateRole handlers (#3672)

* Update AssignRole, RemoveRole and add new UpdateRole handlers Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com> * Update error types based on review feedback Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com> * Do not validate the email Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com> --------- Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
mindersec · Jun 20, 2024 · 7a3bce6 · 7a3bce6
1 parent d08b8f6
commit 7a3bce6
Show file tree

Hide file tree

Showing 3 changed files with 379 additions and 40 deletions.
diff --git a/internal/authz/interface.go b/internal/authz/interface.go
@@ -73,6 +73,9 @@ func (r Role) String() string {
 
 // ParseRole parses a string into a Role
 func ParseRole(r string) (Role, error) {
+	if r == "" {
+		return "", fmt.Errorf("role cannot be empty")
+	}
 	rr := Role(r)
 	if _, ok := AllRoles[rr]; !ok {
 		return "", fmt.Errorf("invalid role %s", r)