Skip to content

Commit

Permalink
Fix entity id in ListEvaluationHistory RPC.
Browse files Browse the repository at this point in the history 
The id returned as id of the entity is the wrong one and must be
fixed. This will probably be followed up by another pull request
addressing the need to return the evaluation id.

Fixes #3932
  • Loading branch information
@blkt
blkt committed Jul 18, 2024
1 parent 079001e commit 960861f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/controlplane/handlers_evalstatus.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func fromEvaluationHistoryRow(
res = append(res, &minderv1.EvaluationHistory{
EvaluatedAt: timestamppb.New(row.EvaluatedAt),
Entity: &minderv1.EvaluationHistoryEntity{
Id: row.EvaluationID.String(),
Id: row.EntityID.String(),

Check failure on line 175 in internal/controlplane/handlers_evalstatus.go

View workflow job for this annotation

GitHub Actions / image-build / Image build 

row.EntityID.String undefined (type interface{} has no field or method String)

Check failure on line 175 in internal/controlplane/handlers_evalstatus.go

View workflow job for this annotation

GitHub Actions / build / Verify build 

row.EntityID.String undefined (type interface{} has no field or method String)

Check failure on line 175 in internal/controlplane/handlers_evalstatus.go

View workflow job for this annotation

GitHub Actions / lint / Run golangci-lint 

row.EntityID.String undefined (type interface{} has no field or method String) (typecheck)

Check failure on line 175 in internal/controlplane/handlers_evalstatus.go

View workflow job for this annotation

GitHub Actions / lint / Run golangci-lint 

row.EntityID.String undefined (type interface{} has no field or method String)) (typecheck)

Check failure on line 175 in internal/controlplane/handlers_evalstatus.go

View workflow job for this annotation

GitHub Actions / compose-migrate / docker 

row.EntityID.String undefined (type interface{} has no field or method String)

Check failure on line 175 in internal/controlplane/handlers_evalstatus.go

View workflow job for this annotation

GitHub Actions / test / Coverage 

row.EntityID.String undefined (type interface{} has no field or method String)

Check failure on line 175 in internal/controlplane/handlers_evalstatus.go

View workflow job for this annotation

GitHub Actions / test / Unit testing 

row.EntityID.String undefined (type interface{} has no field or method String)
Type: entityType,
Name: entityName,
},
Expand Down

0 comments on commit 960861f

Please sign in to comment.