Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
small refactor: Move files around for testability
This moves the evaluation and ingester engines to their own packages. This makes these packages more self-contained and easier to test.
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Copyright 2023 Stacklok, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.role/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // Package rule provides the CLI subcommand for managing rules | ||
|
|
||
| package jq | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| ) | ||
|
|
||
| // ErrEvaluationFailed is an error that occurs during evaluation of a rule. | ||
| var ErrEvaluationFailed = errors.New("evaluation error") | ||
|
|
||
| // NewErrEvaluationFailed creates a new evaluation error | ||
| func NewErrEvaluationFailed(sfmt string, args ...any) error { | ||
| msg := fmt.Sprintf(sfmt, args...) | ||
| return fmt.Errorf("%w: %s", ErrEvaluationFailed, msg) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| // Copyright 2023 Stacklok, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.role/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // Package rule provides the CLI subcommand for managing rules | ||
|
|
||
| // Package ingester provides necessary interfaces and implementations for ingesting | ||
| // data for rules. | ||
| package ingester | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stacklok/mediator/internal/engine/ingester/builtin" | ||
| "github.com/stacklok/mediator/internal/engine/ingester/rest" | ||
| pb "github.com/stacklok/mediator/pkg/generated/protobuf/go/mediator/v1" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestNewRuleDataIngest(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| type args struct { | ||
| rt *pb.RuleType | ||
| access_token string | ||
| } | ||
| tests := []struct { | ||
| name string | ||
| args args | ||
| wantErr bool | ||
| }{ | ||
| { | ||
| name: "rest", | ||
| args: args{ | ||
| rt: &pb.RuleType{ | ||
| Def: &pb.RuleType_Definition{ | ||
| Ingest: &pb.RuleType_Definition_Ingest{ | ||
| Type: rest.RestRuleDataIngestType, | ||
| Rest: &pb.RestType{ | ||
| Endpoint: "https://api.github.com/repos/Foo/Bar", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| name: "rest missing", | ||
| args: args{ | ||
| rt: &pb.RuleType{ | ||
| Def: &pb.RuleType_Definition{ | ||
| Ingest: &pb.RuleType_Definition_Ingest{ | ||
| Type: rest.RestRuleDataIngestType, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| wantErr: true, | ||
| }, | ||
| { | ||
| name: "builtin", | ||
| args: args{ | ||
| rt: &pb.RuleType{ | ||
| Def: &pb.RuleType_Definition{ | ||
| Ingest: &pb.RuleType_Definition_Ingest{ | ||
| Type: builtin.BuiltinRuleDataIngestType, | ||
| Builtin: &pb.BuiltinType{}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| name: "builtin missing", | ||
| args: args{ | ||
| rt: &pb.RuleType{ | ||
| Def: &pb.RuleType_Definition{ | ||
| Ingest: &pb.RuleType_Definition_Ingest{ | ||
| Type: builtin.BuiltinRuleDataIngestType, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| wantErr: true, | ||
| }, | ||
| { | ||
| name: "unsupported", | ||
| args: args{ | ||
| rt: &pb.RuleType{ | ||
| Def: &pb.RuleType_Definition{ | ||
| Ingest: &pb.RuleType_Definition_Ingest{ | ||
| Type: "unsupported", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| wantErr: true, | ||
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| tt := tt | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| got, err := NewRuleDataIngest(tt.args.rt, nil, tt.args.access_token) | ||
| if tt.wantErr { | ||
| require.Error(t, err, "Expected error") | ||
| require.Nil(t, got, "Expected nil") | ||
| return | ||
| } | ||
|
|
||
| require.NoError(t, err, "Unexpected error") | ||
| require.NotNil(t, got, "Expected non-nil") | ||
| }) | ||
| } | ||
| } | ||
Oops, something went wrong.