Skip to content

Commit

Permalink
Rename comment to description in profile's selector message
Browse files Browse the repository at this point in the history
Description plays better with the FE.

Related: #3722
  • Loading branch information
jhrozek committed Jul 17, 2024
1 parent e0b91af commit bcd3132
Show file tree
Hide file tree
Showing 5 changed files with 1,172 additions and 1,170 deletions.
2 changes: 1 addition & 1 deletion docs/docs/ref/proto.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions internal/profiles/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -357,10 +357,10 @@ func selectorsToProfile(
profile.Selection = make([]*pb.Profile_Selector, 0, len(selectors))
for _, s := range selectors {
profile.Selection = append(profile.Selection, &pb.Profile_Selector{
Id: s.ID.String(),
Entity: string(s.Entity.Entities),
Selector: s.Selector,
Comment: s.Comment,
Id: s.ID.String(),
Entity: string(s.Entity.Entities),
Selector: s.Selector,
Description: s.Comment,
})
}
}
2 changes: 1 addition & 1 deletion pkg/api/openapi/minder/v1/minder.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit bcd3132

Please sign in to comment.