Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule_type create is especially prone to timeouts #1383

Closed
jhrozek opened this issue Nov 1, 2023 · 0 comments · Fixed by #1384
Closed

rule_type create is especially prone to timeouts #1383

jhrozek opened this issue Nov 1, 2023 · 0 comments · Fixed by #1384
Assignees
@jhrozek
Labels
bug Something isn't working priority: urgent Urgent request

Comments

@jhrozek
Copy link
Contributor

jhrozek commented Nov 1, 2023

Another thing we saw today on the performance session is that rule_type create is especially prone to timeouts because the context is reused for creating several rule_types.
@jhrozek jhrozek self-assigned this Nov 1, 2023
@jhrozek jhrozek added bug Something isn't working priority: urgent Urgent request labels Nov 1, 2023
@jhrozek jhrozek mentioned this issue Nov 1, 2023
Merged
jhrozek added a commit that referenced this issue Nov 1, 2023
@jhrozek
Use the context in rule_type create for each rule_type (#1384)
d66b78a 
We were passing the 5 second timeout to a function that was invoked in a
loop, so if the cumulative time of operations that used that context
higher than 5 seconds we would get a timeout. This was common with
rule_type create.

Fixes: #1383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhrozek jhrozek

Labels
bug Something isn't working priority: urgent Urgent request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the context in rule_type create for each rule_type jhrozek/mediator
1 participant
@jhrozek