Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GitHub webhook handler to have a case for each event of interest #3359

Closed
blkt opened this issue May 17, 2024 · 0 comments · Fixed by #3346
Closed

Refactor GitHub webhook handler to have a case for each event of interest #3359

blkt opened this issue May 17, 2024 · 0 comments · Fixed by #3346
Assignees

Comments

@blkt
Copy link
Contributor

blkt commented May 17, 2024

Currently, the GitHub webhook handler treats different event types uniformly and the "dispatch logic" for each event is spread over multiple routines. This makes it harder to extend the logic in case new events need to be handled.

Refactor the handler so that every event type has its own routine implementing the necessary business logic.

@blkt blkt self-assigned this May 20, 2024
blkt added a commit that referenced this issue May 21, 2024
…ation.

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
blkt added a commit that referenced this issue May 21, 2024
…ation.

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
blkt added a commit that referenced this issue May 22, 2024
…ation.

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
blkt added a commit that referenced this issue May 24, 2024
…ation.

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
blkt added a commit that referenced this issue May 26, 2024
…ation.

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
blkt added a commit that referenced this issue May 27, 2024
…ation.

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
blkt added a commit that referenced this issue May 27, 2024
…ation.

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
blkt added a commit that referenced this issue May 28, 2024
…ation.

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
blkt added a commit that referenced this issue May 29, 2024
…ation.

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
blkt added a commit that referenced this issue May 29, 2024
…ation.

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
blkt added a commit that referenced this issue May 29, 2024
…ation.

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
blkt added a commit that referenced this issue May 30, 2024
…ation. (#3346)

The idea is to make it easier to extend github webhook with events
that are tied to more than one repository, namely "installation" and
"installation_repositories", which are necessary for repo auto
registration.

Fixes #3359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant