Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add evaluation id to ListEvaluationHistory RPC. #3948

Closed
blkt opened this issue Jul 22, 2024 · 0 comments · Fixed by #3950
Closed

Add evaluation id to ListEvaluationHistory RPC. #3948

blkt opened this issue Jul 22, 2024 · 0 comments · Fixed by #3950
Assignees
@blkt

Comments

@blkt
Copy link
Contributor

blkt commented Jul 22, 2024

In the new ListEvaluationHistory RPC we don't ship the evaluation id as part of the response.
Add it at the same level of the created_at field (here).
@blkt blkt self-assigned this Jul 22, 2024
blkt added a commit that referenced this issue Jul 22, 2024
@blkt
Add evaluation id to ListEvaluationHistory RPC.
4e9345c 
Response message for ListEvaluationHistory RPC contain all sort of ids
except the evaluation id. This change adds it and ensures it is
shipped in the response message.

Fixes #3948
@blkt blkt mentioned this issue Jul 22, 2024
Merged
10 tasks
blkt added a commit that referenced this issue Jul 23, 2024
@blkt
Add evaluation id to ListEvaluationHistory RPC. (#3950)
adcd634 
Response message for ListEvaluationHistory RPC contain all sort of ids
except the evaluation id. This change adds it and ensures it is
shipped in the response message.

Fixes #3948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blkt blkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add evaluation id to ListEvaluationHistory RPC. mindersec/minder
1 participant
@blkt