Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial providers implementation #543

Closed
lukehinds opened this issue Jul 26, 2023 · 1 comment · Fixed by #1011
Closed

Initial providers implementation #543

lukehinds opened this issue Jul 26, 2023 · 1 comment · Fixed by #1011
Assignees

Comments

@lukehinds
Copy link
Contributor

lukehinds commented Jul 26, 2023

While #517 started the scaffolding for projects we still need to have the actual CRUD (both client and server) and actually hook this up into the server.

currently all of our provider implementations are hardcoded to GitHub (which ends up creating a GitHub client from OAuth credentials we store in the database).

The idea is to generalize the providers concept as defined in the document, and track those in the database. For now, providers should be scoped to groups, but once #542 is done we should link them to projects instead.

We'll take the provider from the object's context, and instantiate general clients when they're needed (on policy evaluation). So, we wouldn't rely on GitHub's golang implementation anymore and instead we'd have general REST and GraphQL providers that we can instantiate.

This will allow us to hook in external data sources in a more general way.

@evankanderson
Copy link
Member

Related: #538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants