feat: Actual providers implementation #1011
Conversation
JAORMX
changed the title
JAORMX
force-pushed
the
providers-p2
branch
4 times, most recently
from
c0c779b
to
f7173c0
Compare
|
This works in a basic sense, but I still need to implement the HTTP provider and add configuration options support (which will be read from the DB) |
JAORMX
force-pushed
the
providers-p2
branch
4 times, most recently
from
0478927
to
c90a352
Compare
|
Added basic configurations from the database already. This is ready for feedback @evankanderson @jhrozek @rdimitrov |
JAORMX
force-pushed
the
providers-p2
branch
2 times, most recently
from
eff756e
to
263f087
Compare
JAORMX
changed the title
JAORMX
force-pushed
the
providers-p2
branch
2 times, most recently
from
3571999
to
e60f070
Compare
JAORMX
changed the title
There was a problem hiding this comment.
Can we expect that mediator will continue to fetch updates via a webhook? In that sense would it be useful if we update the current webhook handler to be more provider agnostic by adding to the provider interface methods for populating the initial event message (something similar to what we do when we build the entity wrapper?) but also have a method for processing a web hook event. Anyway, the PR is big enough so I'll approve to not block it 👍
| func (h *REST) Do(ctx context.Context, req *http.Request) (*http.Response, error) { | ||
| req = req.WithContext(ctx) | ||
|
|
||
| return h.cli.Do(req) |
There was a problem hiding this comment.
Closing should happen at the caller's side (the ingester)
Yes, however, I think we'll end up having provider-specific webhook implementations. I'd like it if we could figure out a more flexible way of handling this, but it'll have to wait for later. |
JAORMX
force-pushed
the
providers-p2
branch
from
e60f070
to
cb0b07e
Compare
This defines the provider implementations in such a way that we can instantiate them and check if a rule type is able to accomodate for those. This is done through a new `ProviderBuidler` implementation which is in charge of instantiating the provider type that's needed at a given time. Note that we still use the GitHub provider for HTTP calls since it has a lot of handy features (such as rate limiting handling) that we could leverage.
JAORMX
force-pushed
the
providers-p2
branch
from
cb0b07e
to
a02a354
Compare
|
@jhrozek fixed a merge conflict and resolved your suggestions. |
This defines the provider implementations in such a way that we can instantiate them and check if a rule type is able to accomodate for those.
This is done through a new
ProviderBuidlerimplementation which is in charge of instantiating the provider type that's needed at a given time.Note that we still use the GitHub provider for HTTP calls since it has a lot of handy features (such as rate limiting handling) that we could leverage.
Note that on the way, this removes the GitHub graphql client implementation since it's unused. We may recover it from history if/when needed.
Related-to: #723
Closes: #543