Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move metric server to a separate address #1010

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

rdimitrov
Copy link
Member

The following moves the metrics server in a separate http server and on a dedicated address:port pair.

Fixes #323

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also update the helm charts before merging?

cmd/server/app/serve.go Outdated Show resolved Hide resolved
docker-compose.yaml Show resolved Hide resolved
internal/controlplane/server.go Outdated Show resolved Hide resolved
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
docker-compose.yaml Show resolved Hide resolved
@rdimitrov rdimitrov merged commit 6195eb8 into mindersec:main Sep 25, 2023
12 checks passed
@rdimitrov rdimitrov deleted the metric-server branch September 25, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a dedicated port for metrics
2 participants