feat: Persist provider configuration in protobuf #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
force-pushed
the
providers-proto
branch
3 times, most recently
from
fecf354
to
f9463f1
Compare
This moves the provider configuration from the providers package into the protobuf definitions. This enables us to be able to configure/create/update providers via protobuf in the future. For now, we only have the protobuf structure, but in the future we'll have a `ProvidersService` API that we'll be able to leverage in order to manage providers.
JAORMX
force-pushed
the
providers-proto
branch
from
f9463f1
to
610bf2b
Compare
jhrozek
approved these changes
Sep 26, 2023
|
|
||
| // Validate is a utility function which allows for the validation of a struct. | ||
| func (_ *GitHubProviderConfig) Validate() error { | ||
| // Unfortunately, we don't currently have a way to add custom tags to |
There was a problem hiding this comment.
this is currently empty because not even the API endpoint is required right?
| // - rest | ||
| // - github | ||
| // - git | ||
| repeated string implements = 4; |
There was a problem hiding this comment.
Have you considered an enum instead?
There was a problem hiding this comment.
I'm still not quite sure how to make enums user friendly and string (db) friendly 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the provider configuration from the providers package into the protobuf definitions.
This enables us to be able to configure/create/update providers via protobuf in the future.
For now, we only have the protobuf structure, but in the future we'll have a
ProvidersServiceAPI that we'll be able to leverage in order to manage providers.