fix: don't upsert empty tags as valid value #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
|
Should we add a quick test for this? https://github.com/stacklok/mediator/blob/main/internal/controlplane/handlers_githubwebhooks_test.go shows some examples of mocking the database. |
evankanderson
previously approved these changes
Sep 26, 2023
|
And +1 on adding a test of some sort. |
Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
I'm up for that but let's park it for later 👍 I remember we've talked about this previously when I started creating tests for this exact context and we've decided to leave it for when we refactor the codebase to not be so finicky to mock. |
Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
JAORMX
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue of pushing an empty string as valid (causing len(tags) !=0) in case there was only one tag previously and we removed it upon update.