fix: Also reconcile repo policy run on repo registration #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
commented
Sep 27, 2023
internal/reconcilers/artifacts.go
Outdated
| @@ -125,7 +147,9 @@ func (e *Reconciler) handleArtifactsReconcilerEvent(ctx context.Context, evt *Re | |||
| artifacts, err := cli.ListPackagesByRepository(ctx, isOrg, repository.RepoOwner, | |||
| CONTAINER_TYPE, int64(repository.RepoID), 1, 100) | |||
| if err != nil { | |||
| return fmt.Errorf("error retrieving artifacts: %w", err) | |||
| // we do not return error since it's a valid use case for a repository to not have artifacts | |||
There was a problem hiding this comment.
We probably want to explicitly check that the error is a NotFound error
JAORMX
commented
Sep 27, 2023
| @@ -132,7 +132,7 @@ func (c *RestClient) ListPackagesByRepository(ctx context.Context, isOrg bool, o | |||
| artifacts, resp, err = c.client.Users.ListPackages(ctx, "", opt) | |||
| } | |||
| if err != nil { | |||
| return allContainers, err | |||
| return allContainers, resp, err | |||
There was a problem hiding this comment.
An alternative is to just return an empty list if there's a 404 here, and no error. This way we don't need to expose the response. What do you think?
There was a problem hiding this comment.
I wasn't sure, because we do this pagination where we return what we have so far even in the error case. WDYT, should we keep that?
There was a problem hiding this comment.
Alternatively, what about returning a special error code on 404?
Long term I think we want to move to returning a channel from the List functions and paginate inside the API instead of letting the caller do the work.
JAORMX
force-pushed
the
fix-repo-rec
branch
2 times, most recently
from
3bacc61
to
6b936f8
Compare
We used to only evaluate policy for artifacts when we created a repo. This is not correct. We should also evaluate the repository itself.
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
JAORMX
force-pushed
the
fix-repo-rec
branch
from
6b936f8
to
dc703d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to only evaluate policy for artifacts when we created a repo. This is not
correct. We should also evaluate the repository itself.