Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule and entity filtering to Policy Status list details #1036

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

lujunsan
Copy link
Contributor

@lujunsan lujunsan commented Sep 28, 2023

Add rule name filtering to Policy Status list details, refactor policy status list entity and details conflict
Fixes #908

@lujunsan lujunsan changed the title WIP: Add rule name filtering to Policy Status list details WIP: Add rule and entity filtering to Policy Status list details Sep 28, 2023
@lujunsan lujunsan force-pushed the policy_status_list_details_filters branch 2 times, most recently from 0f34f47 to 74eb63c Compare September 29, 2023 11:05
@lujunsan lujunsan marked this pull request as ready for review September 29, 2023 11:21
@lujunsan lujunsan changed the title WIP: Add rule and entity filtering to Policy Status list details Add rule and entity filtering to Policy Status list details Oct 2, 2023
@lujunsan lujunsan force-pushed the policy_status_list_details_filters branch from 74eb63c to 6d9367b Compare October 2, 2023 11:17
@lujunsan lujunsan requested a review from JAORMX October 2, 2023 12:58
@JAORMX
Copy link
Contributor

JAORMX commented Oct 3, 2023

@lujunsan you need to rebase.

@lujunsan lujunsan force-pushed the policy_status_list_details_filters branch from 6d9367b to dc04fd2 Compare October 3, 2023 07:41
@JAORMX
Copy link
Contributor

JAORMX commented Oct 3, 2023

LGTM shipit! 🚢

@lujunsan lujunsan merged commit d26adbf into main Oct 3, 2023
13 checks passed
@lujunsan lujunsan deleted the policy_status_list_details_filters branch October 3, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow filtering rule evaluation statuses
2 participants