cleanup: Allow for policy files to not specify projects #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to create policies for self-registered users, since they can simply do `medic policy create -f <path to file>` and mediator will just adopt the default project for the user. This also moves the policy validations to the `validations.go` file in our API, since it makes things more predictable. Finally, this removes the context validation, as it's not super useful and we anyway check for this along the code-base.
This also removes the context validation test.
jhrozek
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to create policies for self-registered users, since
they can simply do
medic policy create -f <path to file>and mediatorwill just adopt the default project for the user. To facilitate this, the PR
removes all
project:(and leftovergroup:) assignments in policies and rules,so we can simply take them into use.
This also moves the policy validations to the
validations.gofile in ourAPI, since it makes things more predictable.
Finally, this removes the context validation, as it's not super useful and we anyway
check for this along the code-base.
This also adds the capability for
medic policy createto take a command line flagto overwrite the project being used for the policy.
Closes #1082