Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Rename policy to profile #1108

Merged
merged 1 commit into from
Oct 5, 2023
Merged

cleanup: Rename policy to profile #1108

merged 1 commit into from
Oct 5, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 5, 2023

Per confusion on the name policy this renames that concept into "profiles" instead.

@JAORMX JAORMX force-pushed the policy-to-profile branch 2 times, most recently from ecbdac8 to 96b8e97 Compare October 5, 2023 06:09
@JAORMX JAORMX force-pushed the policy-to-profile branch 3 times, most recently from f9c4973 to d4bf9bf Compare October 5, 2023 06:32
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't scrolled through all the code changes yet (there's too many) but I'm sending an early review so that you can start fixing the k8s manifests

deployment/helm/templates/deployment.yaml Outdated Show resolved Hide resolved
deployment/helm/templates/job.yaml Outdated Show resolved Hide resolved
deployment/helm/templates/job.yaml Outdated Show resolved Hide resolved
Per confusion on the name `policy` this renames that concept into "profiles" instead.
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the changes look good and a basic smoke test of creating a policy and viewing its status passed.

@JAORMX JAORMX merged commit 1028f16 into main Oct 5, 2023
13 checks passed
@JAORMX JAORMX deleted the policy-to-profile branch October 5, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants