fix: Track rule type instantiations in profiles #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts tracking rule type instantions in profiles by introducing a table to track these. This table is populated when creating a new profile and is checked before deleting a rule type. We thus not allow folks to delete rule types if there is a profile instantiating it. Note that the rule type IDs and profile IDs are tracked in the `entity_profile_rules` table using a the `ON DELETE CASCADE` feature. Thus, when a profile is deleted, the instantiations get cleaned up as well. Note that we currently don't support updated profiles (yet), so there was nowhere to add this logic for such a case. This will need to be considered once that feature is implemented. Closes: #1112
jhrozek
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts tracking rule type instantions in profiles by introducing a table to track
these. This table is populated when creating a new profile and is checked
before deleting a rule type. We thus not allow folks to delete rule types
if there is a profile instantiating it.
Note that the rule type IDs and profile IDs are tracked in the
entity_profile_rulestable using a the
ON DELETE CASCADEfeature. Thus, when a profile is deleted, theinstantiations get cleaned up as well.
Note that we currently don't support updated profiles (yet), so there was nowhere to
add this logic for such a case. This will need to be considered once that feature is
implemented.
Closes: #1112