Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logout flow work with new login mechanism #1115

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

eleftherias
Copy link
Contributor

Resolves #1086

Run:
medic auth logout

Result:

You have been logged out of the CLI.
If you would like to log out of the browser, you can visit http://localhost:8081/realms/stacklok/protocol/openid-connect/logout

The alternative is to open the browser on behalf of the user, but that may be too disruptive to their flow.

JAORMX
JAORMX previously approved these changes Oct 5, 2023
cmd/cli/app/auth/auth_logout.go Outdated Show resolved Hide resolved
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is how it looks like:

image

@eleftherias eleftherias merged commit e4b5a08 into mindersec:main Oct 5, 2023
12 checks passed
@eleftherias eleftherias deleted the medic-logout branch October 5, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logout mechanism from mediator CLI
2 participants