Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: update the database layer to support alerts #1116

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Oct 5, 2023

The following PR will include the database changes related to implementing alerts and any refactoring around that.

The goal of this is to update and apply the database changes without breaking any existing functionality and without introducing anything new in terms of features yet.

  • Rename of rule_evaluation_status to rule_evaluations
  • Create new tables for remediations and alerts
  • Update the sqlc generated methods
  • Apply all of that to the existing code base

Fixes: #1114

@rdimitrov rdimitrov marked this pull request as draft October 5, 2023 14:01
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@JAORMX
Copy link
Contributor

JAORMX commented Oct 5, 2023

oh yeah, after every database change, you want to run:

make gen

That'll run the sqlc and mock targets which are quite handy.

@rdimitrov rdimitrov force-pushed the db-updates branch 6 times, most recently from 5a5bc1e to 0d9dc05 Compare October 6, 2023 14:19
@rdimitrov rdimitrov marked this pull request as ready for review October 6, 2023 14:21
@rdimitrov rdimitrov changed the title WIP: db: update the database layer to support alerts db: update the database layer to support alerts Oct 6, 2023
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely and upgrade from the db schema side

@rdimitrov rdimitrov merged commit 9633758 into mindersec:main Oct 6, 2023
12 checks passed
@rdimitrov rdimitrov deleted the db-updates branch October 6, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db: update the database layer to support alerts
3 participants