Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add database migration freeze CI job #1124

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 6, 2023

This adds a CI job that will verify that you don't touch already merged database migrations.

The idea is that if you need to modify the database, you should add an new and working migration,
to keep our deployment working.

This adds a CI job that will verify that you don't touch already merged database migrations.

The idea is that if you need to modify the database, you should add an new and working migration,
to keep our deployment working.
@JAORMX JAORMX marked this pull request as draft October 6, 2023 07:46
@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 6, 2023

Marking as draft, but will aim to merge at the end of the day.

@JAORMX JAORMX marked this pull request as ready for review October 6, 2023 19:18
@lukehinds
Copy link
Contributor

hold for now, it most likely makes sense to reduce the domain model first (remove create/ delete role , org, project etc)

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with Luke, let's get this machinery starting to run

@evankanderson evankanderson merged commit ebae796 into main Oct 9, 2023
13 checks passed
@evankanderson evankanderson deleted the migration-freeze branch October 9, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants