profiles: Allow deleting rule_types if no profiles exist anymore #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no entity_profile_rules rows exist, we don't get an SQL errors, but a slice of 0 values. This would have resulted in: ``` Details: cannot delete: rule type 58e93f07-ff77-4f11-8d6c-d9666a0348b3 is used by profiles ``` (Note that the message is trying to print which profiles by `Join()`-ing the names, but all it has is an empty slices)
JAORMX
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no entity_profile_rules rows exist, we don't get an SQL errors, but a
slice of 0 values. This would have resulted in:
(Note that the message is trying to print which profiles by
Join()-ingthe names, but all it has is an empty slices)