Refresh access token before it expires #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
requested changes
Oct 9, 2023
eleftherias
force-pushed
the
refresh-token
branch
from
b04ff1e
to
5bb13be
Compare
JAORMX
reviewed
Oct 9, 2023
| @@ -57,6 +57,9 @@ func init() { | |||
| RootCmd.PersistentFlags().String("grpc-host", "staging.stacklok.dev", "Server host") | |||
| RootCmd.PersistentFlags().Int("grpc-port", 443, "Server port") | |||
| RootCmd.PersistentFlags().Bool("grpc-insecure", false, "Allow establishing insecure connections") | |||
| RootCmd.PersistentFlags().String("identity-url", "http://localhost:8081", "Identity server issuer URL") | |||
There was a problem hiding this comment.
great! This allows us to change this later to staging keycloak as a default. And then to production.
JAORMX
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1084