Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Keycloak configuration to script #1157

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

eleftherias
Copy link
Contributor

Fix #1151

@eleftherias
Copy link
Contributor Author

@JAORMX It would be great if you could try make identity locally because you have a different setup.

@JAORMX
Copy link
Contributor

JAORMX commented Oct 10, 2023

Love that we no longer carry that big config file. I wonder if we could replace the multiple exec calls with a single init script thay we could set as the container's entrypoint.

@eleftherias
Copy link
Contributor Author

I wonder if we could replace the multiple exec calls with a single init script thay we could set as the container's entrypoint.

@JAORMX We could, but we would require an extra step anyway for users to set their github client credentials for social login. Either setting them in a file or environment variable.
The entrypoint script would also have to have a wait / sleep step until the container is healthy, because it starts executing too early.

@JAORMX
Copy link
Contributor

JAORMX commented Oct 10, 2023

@eleftherias worked like a charm! Let's add docs to mention you need now a two step process to test this out. Otherwise it's good to go. I'd still like this to be a one-step process but we can optimize later on.

@eleftherias
Copy link
Contributor Author

@JAORMX I ended up going with your suggestion and moving the exec calls into the entrypoint, except for the GitHub login. Now Keycloak is set up with the realm and clients when running docker-compose up -d keycloak and then GitHub login is optionally set up when running make KC_GITHUB_CLIENT_ID=<client_id> KC_GITHUB_CLIENT_SECRET=<client_secret> github-login.

Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me!

@eleftherias eleftherias merged commit 3e1c4d0 into mindersec:main Oct 10, 2023
13 checks passed
@eleftherias eleftherias deleted the make-identity branch October 10, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Keycloak configuration to script
2 participants