chore: do not process webhook events for private repos #1162
Conversation
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
| @@ -79,6 +79,9 @@ type UpstreamRepositoryReference struct { | |||
| // ErrRepoNotFound is returned when a repository is not found | |||
| var ErrRepoNotFound = errors.New("repository not found") | |||
|
|
|||
| // ErrRepoIsPrivate is returned when a repository is private | |||
| var ErrRepoIsPrivate = errors.New("repository is private") | |||
There was a problem hiding this comment.
I'm not a fan of processing this as an error. In the near future we'll offer this as an enterprise feature and this route will sneak on us. Instead, let's handle it with an explicit if statement and no error for this.
There was a problem hiding this comment.
Make sense 👍 What do you mean by having no error - revert to returning a generic error or something else?
There was a problem hiding this comment.
FWIW, I don't treat returning an error in this case as..an error..just a way to signal a condition.
There was a problem hiding this comment.
Uhm.... as long as we don't forget later on...
There was a problem hiding this comment.
Okay, so I've added a separate if case so it's more explicit to not forget when we remove it later 👍
Thought of that, but since we don't do a lot of special things based on the error types I did not wanted to expand visually that section too much |
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
rdimitrov
force-pushed
the
no-private-webhook
branch
from
2970435
to
cdfa720
Compare
The following PR updates:
Related to #1083