alerts: update rule type and profile definitions #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
jhrozek
approved these changes
Oct 11, 2023
| message AlertTypeSA { | ||
| string severity = 1; | ||
| } | ||
| optional AlertTypeSA security_advisory = 2; |
There was a problem hiding this comment.
Not for this patch and not your fault, but I think we should have been using oneof for a lot of these types.
There was a problem hiding this comment.
I didn't manage to get json marshal/unmarshal working with oneof. That's the reason we're not using. Feel free to give it another try.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR updates the relevant definitions to support alerts:
alertfield and type of alerts (security-advisory)alertfield for configuring alerts per profile, i.e.on, off, dry-runFixes #1153