-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Great client-side rename #1341
Great client-side rename #1341
Conversation
@@ -5,7 +5,7 @@ | |||
# Feel free to remove those if you don't want/need to use them. | |||
# yaml-language-server: $schema=https://goreleaser.com/static/schema.json | |||
# vim: set ts=2 sw=2 tw=0 fo=cnqoj | |||
project_name: medic | |||
project_name: minder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weren't we thinking to rename the command line to be mindctl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eryn-muetzel -- I thought the CLI was going to be called minder
, but 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I got the minder
name from @meganbruce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought minder was the server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought minder was the server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minder
is the project. I think the idea was to have the CLI for the project use the name of the project, and we can caller the server minder-server
or even a more-cute name if we want. Users will mostly be interacting using the client CLI, so we want that to attach to our brand in their minds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
@@ -41,7 +41,7 @@ archives: | |||
# This section defines how to release to homebrew. | |||
brews: | |||
- homepage: 'https://github.com/stacklok/mediator' | |||
description: 'Medic is the client CLI for interacting with Mediator by Stacklok.' | |||
description: 'minder is the client CLI for interacting with Minder by Stacklok.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mindctl?
@@ -5,7 +5,7 @@ | |||
# Feel free to remove those if you don't want/need to use them. | |||
# yaml-language-server: $schema=https://goreleaser.com/static/schema.json | |||
# vim: set ts=2 sw=2 tw=0 fo=cnqoj | |||
project_name: medic | |||
project_name: minder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought minder was the server
@@ -5,7 +5,7 @@ | |||
# Feel free to remove those if you don't want/need to use them. | |||
# yaml-language-server: $schema=https://goreleaser.com/static/schema.json | |||
# vim: set ts=2 sw=2 tw=0 fo=cnqoj | |||
project_name: medic | |||
project_name: minder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought minder was the server
I meant to approve, not merge... this is what happens when I review from my phone at early hours of the morning... |
Rename all non-functional "mediator" or "medic" client-side strings to "minder". Functional strings (go imports, keycloak client IDs, etc) were not touched.