Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vulncheck's repo cache to be concurrency-friendly #1351

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix vulncheck's repo cache to be concurrency-friendly #1351

merged 2 commits into from
Oct 31, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 31, 2023

This uses xsync's Map instead of a bare map. This way we can avoid the concurrency issues.

@JAORMX
fix: fix vulncheck's repo cache to be concurrency-friendly
0300d04 
This uses xsync's Map instead of a bare map. This way we can avoid the concurrency issues.
eleftherias
eleftherias requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message shouldn't start with fix:

@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 31, 2023

Commit message shouldn't start with fix:

Got a link of acceptable words to use?

@JAORMX JAORMX changed the title fix: fix vulncheck's repo cache to be concurrency-friendly Fix vulncheck's repo cache to be concurrency-friendly Oct 31, 2023
@JAORMX JAORMX requested a review from eleftherias October 31, 2023 10:55
@JAORMX
Copy link
Contributor Author

JAORMX commented Oct 31, 2023

I've removed the fix: word from the PR title.

@JAORMX JAORMX merged commit d49d57e into main Oct 31, 2023
12 checks passed
@JAORMX JAORMX deleted the fix-repo-cache branch October 31, 2023 10:58
This was referenced Nov 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias eleftherias approved these changes

@jhrozek jhrozek Awaiting requested review from jhrozek

@rdimitrov rdimitrov Awaiting requested review from rdimitrov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JAORMX @eleftherias