Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement repo delete for minder #1371

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

rdimitrov
Copy link
Member

The following PR adds a repo delete command to minder.

It takes either a repository name or id and if successful returns the delete name/id as a confirmation. Wasn't sure if this is the correct approach, so can update it if needed 👍

Fixes #875

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested review from JAORMX and jhrozek November 1, 2023 10:26
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It would be nice a message like "Deleted repo with id X" after deletion, instead of printing the JSON response, but that could be added later.

@rdimitrov rdimitrov merged commit 04833e8 into mindersec:main Nov 1, 2023
13 checks passed
@rdimitrov rdimitrov deleted the repo_delete branch November 1, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: add minder repo delete command
3 participants