Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for profiles #1405

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Add docs for profiles #1405

merged 2 commits into from
Nov 2, 2023

Conversation

rdimitrov
Copy link
Member

No description provided.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov self-assigned this Nov 2, 2023
repository:
- type: secret_scanning
def:
enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we talk about different entity types in the text, should we include a profile that has examples for at least two?
We might also want to add an example of the different settings and how to find them in rule_types.
Let me know if you want to merge this first and do a follow-up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but I saw a comment in another PR about keeping things simple so I wasn't sure to which extend I have to put all of the available details here.

I'l add another entity type and have a few sentences providing a simple example of how to find the available settings for a given rule type.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we point to the repo with examples, it would be sufficient

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry forgot to submit the rest of my comments

rules for various entity types, such as repositories, pull requests, and artifacts, across your registered GitHub
repositories.

Profiles are defined in a YAML file and can be easily configured to meet your compliance requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repository:
- type: secret_scanning
def:
enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we point to the repo with examples, it would be sufficient

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov merged commit 3d86a0e into mindersec:main Nov 2, 2023
2 checks passed
@rdimitrov rdimitrov deleted the docs/profiles branch November 2, 2023 21:29
@evankanderson evankanderson mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants