Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference the minder docs from a SA minder alert #1469

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

rdimitrov
Copy link
Member

Refer to the minder remediation docs when we suggest to enable the feature in the SA alert.

Fixes - #1269

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@@ -59,7 +59,7 @@ This advisory will be automatically closed once the issue associated with the **

To address this security exposure, we recommend taking the following actions:

1. Enable the auto-remediate feature within the **{{.Profile}}** profile. This will allow Minder to automatically remediate this and other vulnerabilities in the future, provided that a remediation action is available for the given rule type. In the case of the **{{.Rule}}** rule type, the remediation action is **{{.RuleRemediation}}**.
1. Enable the auto-remediate feature within the **{{.Profile}}** profile by following the [Minder documentation](https://minder.stacklok.github.io/understand/remediation). This will allow Minder to automatically remediate this and other vulnerabilities in the future, provided that a remediation action is available for the given rule type. In the case of the **{{.Rule}}** rule type, the remediation action is **{{.RuleRemediation}}**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently I get a 404, do you want to hold off merging the PR until the pages are live? Also there's a TLS error at the moment at minder.stacklok.github.io is that a known thing @evankanderson ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have synced earlier with Evan if it's okay to start referencing this URL for docs, but I don't have a problem waiting 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then it's probably fine

@JAORMX JAORMX merged commit a09359c into mindersec:main Nov 4, 2023
12 checks passed
@JAORMX JAORMX deleted the ref-docs-from-sa branch November 4, 2023 17:49
@evankanderson evankanderson mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants