Add how-to for pull request remediations #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrozek
reviewed
Nov 4, 2023
|
|
||
| If a repository does not have Dependabot enabled, Minder will create a pull request with the necessary configuration | ||
| to enable it. Alongside the PR, Minder will also create a Security Advisory alert that will be present until the issue | ||
| is resolved. |
There was a problem hiding this comment.
I think we should say two things, in a section on limitations:
- currently the PR remediations can only set file contents, not merge
- if the failing rule is resolved by other means mediator won't close the PR at the moment
There was a problem hiding this comment.
Thanks, I'll them later today
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
rdimitrov
force-pushed
the
pull-request-rem
branch
from
7d16514 to
7e14a3d
Compare
jhrozek
approved these changes
Nov 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.