Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch some more hardcoded strings from using staging + generate CLI docs to point to prod #1476

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Switch some more hardcoded strings from using staging + generate CLI docs to point to prod #1476

merged 3 commits into from
Nov 5, 2023

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Nov 5, 2023

  • Add buildtags to several more go run invocations
  • Convert more staging constant strings to build-time constants
  • Build CLI docs pointing to staging

Please check if the last commit is what we want - but I assume we do, because
why would we generate docs that point to staging.

@jhrozek jhrozek merged commit 940286c into mindersec:main Nov 5, 2023
12 checks passed
@evankanderson evankanderson mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdimitrov rdimitrov rdimitrov approved these changes

@JAORMX JAORMX JAORMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhrozek @JAORMX @rdimitrov