Enable skipping teardown when using the run-docker Makefile target
#1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can use an environment variable to tell our `run-docker` target to skip the teardown phase. It may be done as follows: ```bash export RUN_DOCKER_NO_TEARDOWN=true ``` This will result in subsequent calls to `make teardown` to skip the `docker-compose down` call at the beginning of the run. this is handy for cases where you're doing rapid development and want to keep the database changes.
rdimitrov
reviewed
Nov 8, 2023
rdimitrov
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can use an environment variable to tell our
run-dockertargetto skip the teardown phase. It may be done as follows:
export RUN_DOCKER_NO_TEARDOWN=trueThis will result in subsequent calls to
make teardownto skip thedocker-compose downcall at the beginning of the run.this is handy for cases where you're doing rapid development and want
to keep the database changes.