Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Upgrade otel dependencies #1628

Merged
merged 2 commits into from
Nov 13, 2023
Merged

WIP: Upgrade otel dependencies #1628

merged 2 commits into from
Nov 13, 2023

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Nov 13, 2023

Looks like dependabot wasn't able to figure these on its own.

@jhrozek
Upgrade otel dependencies
7515a70 
Looks like dependabot wasn't able to figure these on its own.
stacklokbot
stacklokbot reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minder analyzed this PR and found no vulnerable dependencies.

@JAORMX
Copy link
Contributor

JAORMX commented Nov 13, 2023

Oops

SA1019: otelgrpc.UnaryServerInterceptor is deprecated: Use [NewServerHandler] instead.  (staticcheck)

@jhrozek
Copy link
Contributor Author

jhrozek commented Nov 13, 2023

interesting, haven't seen that locally.

stacklokbot
stacklokbot reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minder analyzed this PR and found no vulnerable dependencies.

@jhrozek jhrozek marked this pull request as draft November 13, 2023 09:00
JAORMX
JAORMX approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this once it passes CI.

@jhrozek jhrozek changed the title Upgrade otel dependencies WIP: Upgrade otel dependencies Nov 13, 2023
@jhrozek
Copy link
Contributor Author

jhrozek commented Nov 13, 2023

marking as WIP as I need to test this properly but I wanted to see if CI is green in the meantime..

@jhrozek jhrozek marked this pull request as ready for review November 13, 2023 11:58
@jhrozek
Copy link
Contributor Author

jhrozek commented Nov 13, 2023

I made a sanity check of the middleware by just invoking a function that normally requires authentication without being authenticated, that still works.

Seems like the metrics are still working as well:

# HELP minder_rpc_server_duration_milliseconds Measures the duration of inbound RPC.
# TYPE minder_rpc_server_duration_milliseconds histogram
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="0"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="5"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="10"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="25"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="50"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="75"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="100"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="250"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="500"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="750"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="1000"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="2500"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="5000"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="7500"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="10000"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc",le="+Inf"} 1
minder_rpc_server_duration_milliseconds_sum{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc"} 2.9786125e+07
minder_rpc_server_duration_milliseconds_count{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="0",rpc_method="GetUser",rpc_service="minder.v1.UserService",rpc_system="grpc"} 1
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="0"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="5"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="10"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="25"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="50"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="75"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="100"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="250"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="500"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="750"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="1000"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="2500"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="5000"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="7500"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="10000"} 0
minder_rpc_server_duration_milliseconds_bucket{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc",le="+Inf"} 1
minder_rpc_server_duration_milliseconds_sum{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc"} 952875
minder_rpc_server_duration_milliseconds_count{otel_scope_name="go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",otel_scope_version="0.46.0",rpc_grpc_status_code="16",rpc_method="ListRepositories",rpc_service="minder.v1.RepositoryService",rpc_system="grpc"} 1

@jhrozek jhrozek merged commit 07abb48 into mindersec:main Nov 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacklokbot stacklokbot stacklokbot left review comments

@teodor-yanev teodor-yanev teodor-yanev approved these changes

@JAORMX JAORMX JAORMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhrozek @JAORMX @teodor-yanev @stacklokbot