Link PRs with rule_evaluation_status properly #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: mindersec#1608 For some reason (probably refactoring and merging too many patches at the same time?) we no longer linked PRs with evaluation results. This meant that once a PR was merged, the evaluation result was still included.
JAORMX
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason (probably refactoring and merging too many patches at
the same time?) we no longer linked PRs with evaluation results. This
meant that once a PR was merged, the evaluation result was still
included.- Also link PR IDs with evaluation status
To get rid of the dangling references, we delete them in a migration. This is OK, because there are only two events that we listen on:
Fixes: #1608