Handle PR statuses when setting branch protection rules #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GH API returns both `Protection.RequiredStatusChecks.Contexts` which is deprecated and `Protection.RequiredStatusChecks.Checks` which is supposed to be used now on GET, but the PUT update needs to only set one or the other. Let's filter out the deprecated field so that setting branch protection rules when commit statuses are in place works fine. Fixes: mindersec#1596
eleftherias
approved these changes
Nov 14, 2023
rdimitrov
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GH API returns both
Protection.RequiredStatusChecks.Contextswhichis deprecated and
Protection.RequiredStatusChecks.Checkswhich issupposed to be used now on GET, but the PUT update needs to only set one
or the other.
Let's filter out the deprecated field so that setting branch protection
rules when commit statuses are in place works fine.
Fixes: #1596