Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a yes flag to skip prompts for CLI commands #1730

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

hemakshis
Copy link
Contributor

@hemakshis hemakshis commented Nov 27, 2023

Adds an optional --yes/-y flag for bypassing the yes/no prompt.

There are four commands that have this prompt currently,

  1. minder auth revoke_provider
  2. minder auth delete
  3. minder rule_type delete
  4. minder provider enroll

I have added to all the above except minder auth delete as I feel this one should always ask for a confirmation. Let me know if we should add to this one too.

Updated(by @rdimitrov):
Fixes #1519

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

@JAORMX
Copy link
Contributor

JAORMX commented Nov 27, 2023

@hemakshis hey! Thanks a lot for taking the time to look at this. It seems that you have a merge conflict, so you'd have to rebase with the main branch.

@hemakshis hemakshis force-pushed the hemakshis/yes-flag-to-skip-prompts branch from 60ed87f to e924e6f Compare November 27, 2023 16:54
@hemakshis hemakshis force-pushed the hemakshis/yes-flag-to-skip-prompts branch from e924e6f to b64887c Compare November 27, 2023 16:59
Copy link
Member

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hemakshis 💯 🚀

@JAORMX JAORMX merged commit 6ddb67b into mindersec:main Nov 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass in yes flag for minder cli commands that have a prompt message
4 participants