Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue a bespoke profile update message on patching a profile #3012

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Apr 9, 2024

Summary

I forgot to issue a profile update message on patching a profile. Since
the profile update message is currently nicely encapsulated in
sendNewProfileEvent which is a private method of the Profile service
and we already have PR #2990 that would move all of the Patch
functionality to that service and remove the current Patch handler
implementation, I decided to create a bespoke message for now.

This code will be removed once we merge PR #2990.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

  1. create a profile with remediate: off
  2. patch the profile to have remediate: on
  3. with this PR, the profile should re-evaluate

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek jhrozek requested a review from a team as a code owner April 9, 2024 12:45
I forgot to issue a profile update message on patching a profile. Since
the profile update message is currently nicely encapsulated in
`sendNewProfileEvent` which is a private method of the Profile service
and we already have PR mindersec#2990 that would move all of the Patch
functionality to that service and remove the current Patch handler
implementation, I decided to create a bespoke message for now.

This code will be removed once we merge PR mindersec#2990.
@coveralls
Copy link

coveralls commented Apr 9, 2024

Coverage Status

coverage: 48.526% (-0.01%) from 48.538%
when pulling 78852ac on jhrozek:patch_refresh_profile
into 70653d4 on stacklok:main.

@jhrozek jhrozek merged commit 84da02b into mindersec:main Apr 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants