Implement CanImplement method for providers
#3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #2845 Allows both the provider DB record as well as instances of the Provider interface to be queried to determine if they support a particular trait. Will be used more in future PRs.
dmjb
commented
Apr 16, 2024
| return slices.Contains(p.Implements, impl) | ||
| } | ||
|
|
||
| // ProfileRow is an interface row in the profiles table |
There was a problem hiding this comment.
Moved across from store.go - I think it's best to separate out these domain-level methods and data types
dmjb
commented
Apr 16, 2024
| @@ -128,7 +128,7 @@ func NewProviderBuilder( | |||
|
|
|||
| // Implements returns true if the provider implements the given type. | |||
| func (pb *ProviderBuilder) Implements(impl db.ProviderType) bool { | |||
| return slices.Contains(pb.p.Implements, impl) | |||
| return pb.p.CanImplement(impl) | |||
There was a problem hiding this comment.
I have decided to leave this method for now. When my ProviderFactory PR comes along, the ProviderBuilder will be removed entirely. It doesn't seem like a good use of time to clean up all usages of this method.
dmjb
changed the title
CanImplement method for providersCanImplement method for providers
rdimitrov
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2845
Allows both the provider DB record as well as instances of the Provider interface to be queried to determine if they support a particular trait. Will be used more in future PRs.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: