Return 500 if Github AppName is empty when enrolling provider #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did not define this in my local configuration, and it led to some weird errors when enrolling a Github App provider - specificially, it creates a link with an empty app name which will lead to a 404 when the link is acceessed. This will at least return a 500 if the value is omitted, which makes the proble more explicit.
dmjb
changed the title
dmjb
commented
Apr 17, 2024
| @@ -52,6 +52,7 @@ import ( | |||
| // GetAuthorizationURL returns the URL to redirect the user to for authorization | |||
| // and the state to be used for the callback. It accepts a provider string | |||
| // and a boolean indicating whether the client is a CLI or web client | |||
| // nolint:gocyclo | |||
There was a problem hiding this comment.
Not happy about this, but this is another day's problem.
rdimitrov
approved these changes
Apr 17, 2024
teodor-yanev
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not define this in my local configuration, and it led to some weird errors when enrolling a Github App provider - specificially, it creates a link with an empty app name which will lead to a 404 when the link is acceessed. This will at least return a 500 if the value is omitted, which makes the proble more explicit.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: