Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GitHub discussions from README #3129

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Remove GitHub discussions from README #3129

merged 1 commit into from
Apr 18, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner April 18, 2024 07:22
jhrozek
jhrozek approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, we already mention discord

@coveralls
Copy link

Coverage Status

coverage: 48.193% (+0.006%) from 48.187%
when pulling 98aba91 on eleftherias:readme-discussions
into 8421c82 on stacklok:main.

@eleftherias eleftherias merged commit 4aacc91 into mindersec:main Apr 18, 2024
18 checks passed
@eleftherias eleftherias deleted the readme-discussions branch April 18, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eleftherias @coveralls @jhrozek