Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make provider class mandatory in DB #3132

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Make provider class mandatory in DB #3132

merged 2 commits into from
Apr 18, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Apr 18, 2024

Relates to #2845

Undo migration #35 after discussion with Ozz and Jakub this morning. We want the provider class to store the concrete type of the provider, this will be used by the ProviderFactory.

After studying the code, there does not appear to be any situation in which this field will be null in the staging/prod DB.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Relates to #2845

Undo migration #35 after discussion with Ozz and Jakub this morning. We
want the provider class to store the concrete type of the provider, this
will be used by the ProviderFactory.

After studying the code, there does not appear to be any situation in
which this field will be null in the staging/prod DB.
@dmjb dmjb requested a review from a team as a code owner April 18, 2024 17:57
JAORMX
JAORMX previously approved these changes Apr 18, 2024
@coveralls
Copy link

Coverage Status

coverage: 48.162% (+0.02%) from 48.143%
when pulling 7902979 on provider-class-mandatory
into 9139c73 on main.

@dmjb dmjb merged commit 11da628 into main Apr 18, 2024
21 checks passed
@dmjb dmjb deleted the provider-class-mandatory branch April 18, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants