Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip or error when trying to register an archived repository #3135

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

rdimitrov
Copy link
Member

Summary

Currently if we try to register an archived repository we error out because GitHub doesn't allow us to create a webhook in it.

The following PR:

  • Skips listing archived repositories so the user cannot choose them.
  • Added a dedicated error type/message in case the user tries to register one explicitly via the CLI
  • Fixed an issue where if we failed to register any repositories, we still printed a table in the CLI.

Fixes #1428

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Tested locally with an archived repository

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov requested a review from a team as a code owner April 18, 2024 22:22
@rdimitrov rdimitrov changed the title Skip or error when trying to registered an archived repository Skip or error when trying to registere an archived repository Apr 18, 2024
@rdimitrov rdimitrov changed the title Skip or error when trying to registere an archived repository Skip or error when trying to register an archived repository Apr 18, 2024
@coveralls
Copy link

coveralls commented Apr 18, 2024

Coverage Status

coverage: 48.148% (-0.01%) from 48.162%
when pulling b5881b1 on archived
into 38bf147 on main.

@rdimitrov rdimitrov merged commit 9a1a4ab into main Apr 19, 2024
19 checks passed
@rdimitrov rdimitrov deleted the archived branch April 19, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle archived repos
3 participants