Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address review comments for labels filtering #3137

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Apr 19, 2024

Summary

In the interest of time we merged labels filtering with some comments
not being addressed. This patch fixes that:

  • exclude_labels now excludes any profiles containing any of the exclude
    labels. Add a test for this new behaviour.
  • fix confusing comment in LabelsFromFilter
  • special-case wildcard matching to only return the wildcard
  • sort the slice in test to avoid issues where the slices contain the
    right elements, but in wrong order

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

make test

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

In the interest of time we merged labels filtering with some comments
not being addressed. This patch fixes that:
- exclude_labels now excludes any profiles containing any of the exclude
  labels. Add a test for this new behaviour.
- fix confusing comment in LabelsFromFilter
- special-case wildcard matching to only return the wildcard
- sort the slice in test to avoid issues where the slices contain the
  right elements, but in wrong order
@jhrozek jhrozek requested a review from a team as a code owner April 19, 2024 08:28
@coveralls
Copy link

coveralls commented Apr 19, 2024

Coverage Status

coverage: 48.16% (+0.02%) from 48.143%
when pulling 40416ee on jhrozek:labels_comments
into 9a1a4ab on stacklok:main.

@jhrozek jhrozek merged commit 0796ff8 into mindersec:main Apr 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants