Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove provider name from event wrapper #3139

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Remove provider name from event wrapper #3139

merged 3 commits into from
Apr 22, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Apr 19, 2024

Fixes #3071

Final step in the process in migrating over to provider ID instead of provider name.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Fixes #3071

Final step in the process in migrating over to provider ID instead of
provider name.
@coveralls
Copy link

coveralls commented Apr 19, 2024

Coverage Status

coverage: 47.861% (-0.02%) from 47.877%
when pulling 3772ee2 on eiw-remove-provider-name
into 35af4fe on main.

@dmjb dmjb changed the title [DO NOT MERGE] Remove provider name from event wrapper Remove provider name from event wrapper Apr 22, 2024
@dmjb dmjb marked this pull request as ready for review April 22, 2024 10:49
@dmjb dmjb requested a review from a team as a code owner April 22, 2024 10:49
@dmjb dmjb merged commit 5964281 into main Apr 22, 2024
20 checks passed
@dmjb dmjb deleted the eiw-remove-provider-name branch April 22, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Provider name from EntityInfoWrapper
3 participants